-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for building rhel8 kernels #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use the default interface (aka IDE) to attach the hard disk image to the VM. IDE support has bitrotted on RHEL8 kernels and can't be enabled. Add an option to attach using the newer and more appropriate virtio interface instead. Signed-off-by: Lorenz Bauer <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
Remove debugging statement erroneously introduced in commit 06c67d1. Signed-off-by: Kornilios Kourtis <[email protected]>
This will be used in a subsequent patch for configuring kernels fetched outside of lvh. Signed-off-by: Kornilios Kourtis <[email protected]>
lvh assumes that kernels can be build by fetching them with git. This, however, is not always possible. centos/rhel kernels are an example of this. It would still be nice to use lvh to configure these kernels. This patch adds a raw_configure command that allows just that. The command accepts a source directory for the kernel, and an optional kernel name. The latter is used for kernel-specific options as defined in the configuration. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jan 22, 2024
Use: docker build -f dockerfiles/kernel-images-rhel8 . Requres: cilium/little-vm-helper#144 Signed-off-by: Lorenz Bauer <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
lmb
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, how would we slot raw_configure into the kernel build?
|
kkourt
added a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jan 23, 2024
Use: docker build -f dockerfiles/kernel-images-rhel8 . Requres: cilium/little-vm-helper#144 Signed-off-by: Lorenz Bauer <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jan 24, 2024
Use: docker build -f dockerfiles/kernel-images-rhel8 . Requres: cilium/little-vm-helper#144 Signed-off-by: Lorenz Bauer <[email protected]> Signed-off-by: Kornilios Kourtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes an alternative version of #142