Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for building rhel8 kernels #144

Merged
merged 4 commits into from
Jan 23, 2024
Merged

support for building rhel8 kernels #144

merged 4 commits into from
Jan 23, 2024

Conversation

kkourt
Copy link
Collaborator

@kkourt kkourt commented Jan 22, 2024

Includes an alternative version of #142

We currently use the default interface (aka IDE) to attach the hard disk
image to the VM. IDE support has bitrotted on RHEL8 kernels and can't be
enabled. Add an option to attach using the newer and more appropriate
virtio interface instead.

Signed-off-by: Lorenz Bauer <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
Remove debugging statement erroneously introduced in commit 06c67d1.

Signed-off-by: Kornilios Kourtis <[email protected]>
This will be used in a subsequent patch for configuring kernels fetched
outside of lvh.

Signed-off-by: Kornilios Kourtis <[email protected]>
lvh assumes that kernels can be build by fetching them with git. This,
however, is not always possible. centos/rhel kernels are an example of
this. It would still be nice to use lvh to configure these kernels.

This patch adds a raw_configure command that allows just that.

The command accepts a source directory for the kernel, and an optional
kernel name. The latter is used for kernel-specific options as defined
in the configuration.

Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt added a commit to cilium/little-vm-helper-images that referenced this pull request Jan 22, 2024
Use:
docker build -f dockerfiles/kernel-images-rhel8 .

Requres: cilium/little-vm-helper#144

Signed-off-by: Lorenz Bauer <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt requested a review from lmb January 22, 2024 14:15
Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how would we slot raw_configure into the kernel build?

@kkourt
Copy link
Collaborator Author

kkourt commented Jan 23, 2024

LGTM, how would we slot raw_configure into the kernel build?

cilium/little-vm-helper-images#323 :)

@kkourt kkourt merged commit ee06006 into main Jan 23, 2024
1 check passed
@kkourt kkourt deleted the pr/kkourt/rhel8-support branch January 23, 2024 17:41
kkourt added a commit to cilium/little-vm-helper-images that referenced this pull request Jan 23, 2024
Use:
docker build -f dockerfiles/kernel-images-rhel8 .

Requres: cilium/little-vm-helper#144

Signed-off-by: Lorenz Bauer <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt added a commit to cilium/little-vm-helper-images that referenced this pull request Jan 24, 2024
Use:
docker build -f dockerfiles/kernel-images-rhel8 .

Requres: cilium/little-vm-helper#144

Signed-off-by: Lorenz Bauer <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants