action: Remove setting DNS resolver #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilium/little-vm-helper-images#187 resolves the issue with Azure DNS resolvers. Signed-off-by: Martynas Pumputis <[email protected]>
aanm
approved these changes
Sep 29, 2023
mhofstetter
added a commit
to cilium/cilium
that referenced
this pull request
Nov 29, 2023
With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
added a commit
to cilium/cilium
that referenced
this pull request
Nov 29, 2023
The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Nov 29, 2023
With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Nov 29, 2023
The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 13, 2023
[ upstream commit a2694fc ] [ backporter's notes: skipped changes in conformance-ginkgo.yaml, conformance-runtime.yaml, tests-datapath-verifier.yaml and tests-e2e-upgrade.yaml, as not present in v1.13. ] The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 13, 2023
[ upstream commit 1c10df2 ] With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 13, 2023
[ upstream commit a2694fc ] [ backporter's notes: skipped changes in tests-e2e-upgrade.yaml, as not present in v1.14. ] The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 13, 2023
[ upstream commit 1c10df2 ] With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
giorio94
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 13, 2023
[ upstream commit a2694fc ] [ backporter's notes: skipped changes in tests-e2e-upgrade.yaml, as not present in v1.14. ] The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
ldelossa
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 13, 2023
[ upstream commit a2694fc ] [ backporter's notes: skipped changes in conformance-ginkgo.yaml, conformance-runtime.yaml, tests-datapath-verifier.yaml and tests-e2e-upgrade.yaml, as not present in v1.13. ] The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 14, 2023
[ upstream commit 1c10df2 ] With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Dec 14, 2023
[ upstream commit a2694fc ] [ backporter's notes: skipped changes in tests-e2e-upgrade.yaml, as not present in v1.14. ] The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]> Signed-off-by: Marco Iorio <[email protected]>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
With the removal of setting a nameserver via the little-vm-helper GitHub action, conformance-runtime tests are failing quite often with the following error. ``` dial tcp: lookup quay.io on 127.0.0.53:53: read udp 127.0.0.1:40553->127.0.0.53:53: read: connection refused ``` The assumption is that the local DNS resolver isn't ready at that time when pulling the image. Therefore, this way temporarily re-adds the nameserver `1.1.1.1` manually. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
The property dns-resolver has been removed from the little-vm-helper GitHub action. Therefore, this commit removes the usage of it in the cilium repository. See: cilium/little-vm-helper#118 Signed-off-by: Marco Hofstetter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium/little-vm-helper-images#187 resolves the issue with Azure DNS resolvers.