Dockerfile: ensure json-server terminates on SIGTERM #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the json-server process terminates upon reception of the SIGTERM signal, so that the pod doesn't remain in terminating status for 30 seconds (the default grace period) when deleted. This fix involves two changes: * Run exec at the end of the run.sh script, instead of shelling out, so that the callee gets PID 1; * Wrap the json-server executable with the "tini" lightweight init system, as apparently node doesn't terminate upon SIGTERM when running as PID 1. Signed-off-by: Marco Iorio <[email protected]>
nickolaev
approved these changes
Jan 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the json-server process terminates upon reception of the SIGTERM signal, so that the pod doesn't remain in terminating status for 30 seconds (the default grace period) when deleted. This fix involves two changes: