Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dockerfile #1631

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove Dockerfile #1631

merged 1 commit into from
Dec 11, 2024

Conversation

michi-covalent
Copy link
Collaborator

Hubble CLI binary already gets shipped as a part of the Cilium Agent image, so let's not maintain yet another image.

  • Remove Dockerfile and build-images-release.yaml.
  • Put release.yml in the release GitHub environment.

Hubble CLI binary already gets shipped as a part of the Cilium Agent
image, so let's not maintain yet another image.

- Remove Dockerfile and build-images-release.yaml.
- Put release.yml in the release GitHub environment.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent requested review from a team and glibsm and removed request for a team December 10, 2024 15:32
@michi-covalent michi-covalent requested review from a team as code owners December 10, 2024 15:32
@michi-covalent michi-covalent requested review from aanm and Artyop and removed request for a team December 10, 2024 15:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label PR is blocked until the release note is set label Dec 10, 2024
@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Dec 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label PR is blocked until the release note is set label Dec 10, 2024
@michi-covalent
Copy link
Collaborator Author

cc @cilium/hubble-maintainers what do you think about this change 👀

.github/workflows/release.yml Show resolved Hide resolved
@michi-covalent michi-covalent requested a review from aanm December 10, 2024 17:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 10, 2024
@rolinh rolinh merged commit af3d8bd into main Dec 11, 2024
3 checks passed
@rolinh rolinh deleted the pr/michi/no-docker branch December 11, 2024 08:30
@rolinh rolinh mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants