script: Use pflag for command arguments #30
Merged
+180
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
requested review from
dylandreimerink and
ovidiutirla
and removed request for
a team
joamaki
force-pushed
the
pr/joamaki/script-pflag
branch
from
3e5a42b to
148a40a
Compare
|
Validated in |
dylandreimerink
approved these changes
Dec 12, 2024
joamaki
force-pushed
the
pr/joamaki/script-pflag
branch
4 times, most recently
from
5ec99e3 to
55b68a7
Compare
Embed the pflag FlagSet into the command creation so we can show decent help for the flags. Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/script-pflag
branch
from
55b68a7 to
92e3445
Compare
|
Converted statedb to use this: cilium/statedb#70. That unfortunately won't be backwards compatible and will need to fix things up when StateDB will be bumped. |
ovidiutirla
approved these changes
Dec 13, 2024
| if len(args) > 0 && args[0] == "-q" { | ||
| quiet = true | ||
| args = args[1:] | ||
| quiet, err := s.Flags.GetBool("quiet") |
There was a problem hiding this comment.
nit: would be nice to extract these as consts (quiet)
Comment on lines
+588
to
+589
| fs.Bool("readonly", false, "File must not be writable") | ||
| fs.Bool("exec", false, "File must not be executable") |
There was a problem hiding this comment.
nit: also these flags too, maybe? I was thinking to have a way to be able to re-use these flags that have high chance to be re-used across cmds.
| @@ -637,26 +643,20 @@ func Grep() Cmd { | |||
| }) | |||
| } | |||
|
|
|||
| const matchUsage = "[-count=N] [-q] 'pattern'" | |||
| func matchFlags(fs *pflag.FlagSet) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embed the pflag FlagSet into the command creation so we can show decent help for the flags.
The
CmdUsagenow contains aFlagsfield of typefunc(*pflag.FlagSet)(similar tocell.Flagger!) thatallows registering the flags. These flags are then shown in the help summary, e.g.
[-q] [--quiet]forfs.BoolP("quiet", "q", ...)and also expanded in the verbose help.For example
helpnow looks like: