Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection: document garbage collection behaviour of *Map and *Program #579

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

ti-mo
Copy link
Collaborator

@ti-mo ti-mo commented Feb 21, 2022

Since this behaviour can be surprising, especially in the face of prog arrays, document the recommended usage on functions returning a Collection.

@lmb Should this be echoed in the package doc as well?

#578

@ti-mo ti-mo requested a review from lmb February 21, 2022 12:57
@ti-mo ti-mo force-pushed the tb/document-prog-map-gc branch from b7a41e3 to 41fca98 Compare February 23, 2022 11:17
Since this behaviour can be surprising, especially when handling prog arrays,
document the recommended usage on functions returning Collection/Map/Program.

Signed-off-by: Timo Beckers <[email protected]>
@ti-mo ti-mo force-pushed the tb/document-prog-map-gc branch from 41fca98 to f8bac46 Compare February 23, 2022 11:20
@ti-mo ti-mo merged commit 07fff6e into cilium:master Feb 23, 2022
@ti-mo ti-mo deleted the tb/document-prog-map-gc branch February 23, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants