features: make HaveProgramHelper more accurate #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmb
force-pushed
the
features-helper-probe
branch
2 times, most recently
from
1afe479 to
ee5d9a6
Compare
florianl
reviewed
Jan 10, 2025
lmb
force-pushed
the
features-helper-probe
branch
from
ee5d9a6 to
710ebd1
Compare
rgo3
approved these changes
Jan 10, 2025
Parse the verifier output to figure out whether a helper call is really not supported. This makes the result more reliable and allows us to get rid of asm.BuiltinFunc.Max(). Signed-off-by: Lorenz Bauer <[email protected]>
lmb
force-pushed
the
features-helper-probe
branch
from
710ebd1 to
25d61ba
Compare
No, the motivation is to get rid of |
florianl
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the verifier output to figure out whether a helper call is really not supported. This makes the result more reliable and allows us to get rid of asm.BuiltinFunc.Max().