-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link: add Info() method to all link types #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
force-pushed
the
add-info-implementations
branch
from
May 16, 2024 11:34
0226417
to
01982d5
Compare
borkmann
reviewed
May 23, 2024
borkmann
reviewed
May 23, 2024
rgo3
force-pushed
the
add-info-implementations
branch
from
May 23, 2024 12:16
01982d5
to
53dffd2
Compare
rgo3
commented
May 23, 2024
rgo3
commented
May 23, 2024
rgo3
commented
May 23, 2024
rgo3
commented
May 23, 2024
Signed-off-by: Robin Gögge <[email protected]>
rgo3
force-pushed
the
add-info-implementations
branch
from
May 23, 2024 15:51
53dffd2
to
f508e58
Compare
lmb
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
mmat11
approved these changes
May 23, 2024
Thanks as always :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out retrieving linktype-specific metadata from
RawLink.Info()
. This will reduce the amount of syscalls when callingRawLink.Info()
directly. If needed the inktype-specific metadata can now be retrieved through linktype-specificInfo()
methods.