bump golang.org/x/sys from 0.6.0 to v0.14.0 #1206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lfbzhm <[email protected]>
|
The correct fix is to wait for a release of x/sys which has the constant and then update your minimum version to that. Seems like there is already a CL ongoing, see the upstream Go issue. |
tklauser
added a commit
to tklauser/ebpf
that referenced
this pull request
Nov 9, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will break the build because of the missing definition of BPF_F_KPROBE_MULTI_RETURN, see golang/go#63969 and cilium#1206. This was fixed upstream in https://go.dev/cl/540395, so manually pull in the latest unreleased version to allow modules depending on cilium/ebpf to update to later versions as well. Signed-off-by: Tobias Klauser <[email protected]>
lmb
pushed a commit
that referenced
this pull request
Nov 9, 2023
Updating golang.org/x/sys/unix to the recently released v0.14.0 will break the build because of the missing definition of BPF_F_KPROBE_MULTI_RETURN, see golang/go#63969 and #1206. This was fixed upstream in https://go.dev/cl/540395, so manually pull in the latest unreleased version to allow modules depending on cilium/ebpf to update to later versions as well. Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we still use
golang.org/x/syswith the version0.6.0, it makes us can't bump it to the latest version0.14.0in other projects depending ongithub.aaakk.us.kg/cilium/ebpf.Please see opencontainers/runc#4108