link: fix nil pointer dereference in AttachXDP

Signed-off-by: Gavin Bunney <[email protected]>

link/xdp.go

@@ -51,7 +51,11 @@ func AttachXDP(opts XDPOptions) (Link, error) {
 		Flags:   uint32(opts.Flags),
 	})
 
-	return &xdpLink{*rawLink}, err
+	if err != nil {
+		return nil, fmt.Errorf("failed to attach link: %w", err)
+	}
+
+	return &xdpLink{*rawLink}, nil
 }
 
 type xdpLink struct {

link/xdp_test.go

@@ -1,10 +1,12 @@
 package link
 
 import (
+	"math"
 	"testing"
 
 	"github.com/cilium/ebpf"
 	"github.com/cilium/ebpf/internal/testutils"
+	"github.com/go-quicktest/qt"
 )
 
 const IfIndexLO = 1
@@ -14,13 +16,17 @@ func TestAttachXDP(t *testing.T) {
 
 	prog := mustLoadProgram(t, ebpf.XDP, 0, "")
 
+	_, err := AttachXDP(XDPOptions{
+		Program:   prog,
+		Interface: math.MaxInt,
+	})
+	qt.Assert(t, qt.IsNotNil(err))
+
 	l, err := AttachXDP(XDPOptions{
 		Program:   prog,
 		Interface: IfIndexLO,
 	})
-	if err != nil {
-		t.Fatal(err)
-	}
+	qt.Assert(t, qt.IsNil(err))
 
 	testLink(t, l, prog)
 }