Fixed handling of dead code #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two situations involving dead code that coverbee did not handle well. If the last part of a program contained dead code, the list of merged states would be shorter than the list of instructions since the verifier log never covered that part, causing a panic. The second situation would be when there is dead code in the middle of a program. In which case we would only have a "blank" state, and we would start using registers which might already be in use. If one of these situations is detected, we will still instrument the program but assume we have no registers available which is the worst case but also always save. Signed-off-by: Dylan Reimerink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two situations involving dead code that coverbee did not handle well. If the last part of a program contained dead code, the list of merged states would be shorter than the list of instructions since the verifier log never covered that part, causing a panic.
The second situation would be when there is dead code in the middle of a program. In which case we would only have a "blank" state, and we would start using registers which might already be in use.
If one of these situations is detected, we will still instrument the program but assume we have no registers available which is the worst case but also always save.