Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tamilmani1989 to fqdn reviewer group #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tamilmani1989
Copy link
Contributor

I have been reviewing and contributing to FQDN for sometime and continue to do going forward.

@xmulligan
Copy link
Member

Cc @cilium/fqdn

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tamilmani1989!

@tamilmani1989 tamilmani1989 changed the title add tamilamni1989 to fqdn reviewer group add tamilmani1989 to fqdn reviewer group Dec 10, 2024
@joestringer
Copy link
Member

Thanks for your willingness to contribute and help maintain Cilium @tamilmani1989 , we'd love to see you join the group assuming the reviewer expectations are met :)

I see that we're looking for @cilium/fqdn codeowners / committers feedback on this proposal. As a matter of process, it could help this proposal if you could link to example contributions or reviews to help the codeowners to see your contributions particularly in this area. Even a general link to PRs/issues authored by you (example), or individual PRs where you were heavily involved in review.

If members of @cilium/fqdn are not yet comfortable in adding you to the group that approves / gets assigned reviews, then perhaps @cilium/fqdn could provide pointers as to what they'd expect to see. Even before you become part of the group, we would welcome you to continue to contribute by sending PRs to improve the area and review PRs requesting feedback from @cilium/fqdn. Every contribution you make will help to build your reputation with other contributors and give confidence that the quality bar we uphold in this area as a community will continue to be upheld with your assistance.

@joestringer
Copy link
Member

For FQDN area in general, one thing that I expect will go a long way to demonstrating a track record would be inclusion of a major feature like the one you are actively working on. For a similar example of demonstrating the track record, you can also see this PR which highlights several bugfixes the contributor worked on which all involve quite nuanced behavior in the internals of this area of the codebase.

@tamilmani1989
Copy link
Contributor Author

My contributions so far:

cilium/design-cfps#54
cilium/cilium#36121

Review:
cilium/cilium#33989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants