-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli to display ipcache by labels #35275
Conversation
Commit 5a5b83b does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
CLI display from my testing:
Query by CIDR:
|
Commits 5a5b83b, 5d73957 do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
@vasu-dasari Please sign-off your first commit and remove the last empty commit. Thanks 🙂 ! |
@vasu-dasari Pinging you on getting this merged. Please sign-off your first commit and remove the empty last commit from your PR. Thanks! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit otherwise lgtm!
@vasu-dasari Could you take another look when you get a chance? Thank you! |
Commits 5a5b83b, 5d73957, 3e11c1f do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1 similar comment
Commits 5a5b83b, 5d73957, 3e11c1f do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Signed-off-by
to my commit. And addressed comment from @doniacld
Commits 5a5b83b, 5d73957, 3e11c1f, 5776676 do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1 similar comment
Commits 5a5b83b, 5d73957, 3e11c1f, 5776676 do not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 3aa5c9a does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commit 9f19d48 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Added new CLI to display ipcache entries by cidr and labels. Display IP Cache information Usage: cilium-dbg ip get ( <cidr> |-l <identity labels> ) [flags] Flags: -h, --help help for get -l, --labels strings list of labels -o, --output string json| yaml| jsonpath='{}' -v, --verbose Print all fields of ipcache Fixes: cilium#34632 Signed-off-by: Vasu Dasari <[email protected]>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the change
Added new CLI to display ipcache entries by cidr and labels.
Display IP Cache information
Fixes: #34632
Signed-off-by: Vasu Dasari [email protected]