fix(cilium-cli/status): add helmReleaseName parameter #34748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
cilium-cli
The status command did not use the helmReleaseName set by the cli, causing it to do a lookup of a helm release with an empty string as helmReleaseName. This results in error and no version reported by the status command. This commit adds the helmReleaseName parameter so the global value is inherited by the status command. Fixes: cilium#34747 Signed-off-by: Pelle van Gils <[email protected]>
pgils
force-pushed
the
fix/status-helm-version
branch
from
cea2dcd to
4e74c15
Compare
nathanjsweet
approved these changes
Sep 9, 2024
|
/test |
dylandreimerink
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status command did not use the helmReleaseName set by the cli, causing it to do a lookup of a helm release with an empty string as helmReleaseName. This results in error and no version reported by the status command.
This commit adds the helmReleaseName parameter so the global value is inherited by the status command.
Fixes: #34747