-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daemon/cmd: fix a couple of func doc string #25030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cuishuang thanks for the PR and good catch.
Could you please rephrase the commit message and PR title to something a tad more descriptive? e.g. "daemon/cmd: fix a couple of func doc string"
Of course!Done |
@cuishuang Thanks for the update, please change the commit message as well, you can do it with % git commit --amend
% git push --force-with-lease |
Thanks! Done |
Signed-off-by: cui fliter <[email protected]>
generate-k8s-api CI failure is unrelated to the patch (opened #25192 to workaround the issue), all other checks are green and reviews in (no need for a full CI run) so marking as |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Fixes: #issue-number