renovate: Update builder and runtime images once a week #24846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
approved these changes
Apr 12, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The golang image SHAs keep changing even for the same patch version, and renovate keeps opening pull requests like this one: #24831 Let's try limiting these updates to once a week. It should be enough since we only release patch versions once a month. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/renovate
branch
from
fa1e2a5 to
48ccfe7
Compare
|
I don't think this change was effective. Renovate just opened a PR updating some digests on a Thursday: #24861
|
|
ah i think i know what's going on. https://github.com/cilium/cilium/pull/24861/files is not updating runtime/builder images, but it's updating:
let's rate-limit these as well ✅ |
michi-covalent
added a commit
that referenced
this pull request
Apr 13, 2023
We added weekly schedule for the builder and runtime images in #24846. There are other Dockerfiles that directly use docker.io/library/golang for building (see #24861). Let's do the same weekly update for these images. Signed-off-by: Michi Mutsuzaki <[email protected]>
This was referenced Apr 13, 2023
michi-covalent
added a commit
that referenced
this pull request
Apr 14, 2023
We added weekly schedule for the builder and runtime images in #24846. There are other Dockerfiles that directly use docker.io/library/golang for building (see #24861). Let's do the same weekly update for these images. Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The golang image SHAs keep changing even for the same patch version, and renovate keeps opening pull requests like this one:
#24831
Let's try limiting these updates to once a week. It should be enough since we only release patch versions once a month.