Test runtime cilium in container (take two) #19310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
area/CI
|
/test-runtime |
jrajahalme
force-pushed
the
test-runtime-cilium-in-container-take-two
branch
from
a632c14 to
11186e3
Compare
|
/test-runtime |
jrajahalme
force-pushed
the
test-runtime-cilium-in-container-take-two
branch
from
11186e3 to
25a7188
Compare
|
/test-runtime |
jrajahalme
force-pushed
the
test-runtime-cilium-in-container-take-two
branch
from
25a7188 to
7d5f689
Compare
|
Fixed image references to start with "quay.io" |
|
/test-runtime |
jrajahalme
force-pushed
the
test-runtime-cilium-in-container-take-two
branch
from
7d5f689 to
269ff08
Compare
|
Noticed that |
|
/test-runtime |
Runtime tests do not need images used by k8s tests, nor do k8s tests need images used by runtime tests. Pull images only for the test suite in use. Signed-off-by: Jarno Rajahalme <[email protected]>
Run Cilium in docker container for the Runtime tests. Keep the systemd cilium.service, but uses a new script to run Cilium from a docker container from there. This design has a high degree of compatibility to the prior running cilium-agent directly from cilium.docker. Test scripts are organized so that there is no change when running CIlium in a development VM. There cilium-agent is still run in the host as before. While working with this I noticed that CIlium operator fails to run in Runtime tests as it now assumes to be able to reach k8s api-server. CIlium agent fails after a while due to this if it is using etcd kvstore as the heartbeats are missing. That's why the kvstore needs to return to the default (consul) configuration after the etcd test. Previously this was done after each test, but now this is done after all (two) of the kvstore tests, speeding up the tests a bit. Do not pass explicit options when they are the same as defaults. This also avoids using systemd template where bare Cilium agent options are expected. Signed-off-by: Jarno Rajahalme <[email protected]>
Pass CILIUM_IMAGE and CILIUM_TAG from environment to provisioning. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added a commit
to jrajahalme/cilium
that referenced
this pull request
Apr 9, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: cilium#19310 Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added a commit
to jrajahalme/cilium
that referenced
this pull request
Apr 9, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: cilium#19310 Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added a commit
to jrajahalme/cilium
that referenced
this pull request
Apr 9, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: cilium#19310 Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added a commit
to jrajahalme/cilium
that referenced
this pull request
Apr 12, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: cilium#19310 Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added a commit
to jrajahalme/cilium
that referenced
this pull request
Apr 12, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: cilium#19310 Signed-off-by: Jarno Rajahalme <[email protected]>
This was referenced Apr 12, 2022
nbusseneau
pushed a commit
that referenced
this pull request
Apr 12, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: #19310 Signed-off-by: Jarno Rajahalme <[email protected]>
maintainer-s-little-helper
bot
added
the
ready-to-merge
nbusseneau
pushed a commit
that referenced
this pull request
Apr 13, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: #19310 Signed-off-by: Jarno Rajahalme <[email protected]>
tklauser
pushed a commit
that referenced
this pull request
Apr 13, 2022
[ upstream commit 262ac5f ] Add space between provided and default args. Fixes: #19310 Signed-off-by: Jarno Rajahalme <[email protected]>
tklauser
added
backport-done/1.11
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Cilium in docker container for the Runtime tests. This is needed so that cilium-envoy built on Ubuntu 20.04 runs also on earlier versions when the correct version of libc is in the container image.
This version keeps the systemd cilium.service, but uses a new script to run Cilium from a docker container from there within Runtime tests. This design has a high degree of compatibility to the prior running cilium-agent directly from cilium.docker.
Test scripts are organised so that there is no change when running CIlium in a development VM. There cilium-agent is still run in the host as before.
While working with this I noticed that CIlium operator fails to run in Runtime tests as it now assumes to be able to reach k8s api-server. Because of this it is pointless to deploy
cilium-operatorfor runtime tests. CIlium agent fails after a while due to this if it is using etcd kvstore as the heartbeats are missing. That's why the kvstore needs to return to the default (consul) configuration after the etcd test. Previously this was done after each test, but now this is done after all (two) of the kvstore tests, speeding up the tests a bit.Fixes: #18919