Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.12.0 release #983

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Prepare for v0.12.0 release #983

merged 1 commit into from
Jul 19, 2022

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser
Prepare for v0.12.0 release
fab50d8 
Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser requested a review from michi-covalent July 19, 2022 14:45
@tklauser tklauser requested a review from a team as a code owner July 19, 2022 14:45
@tklauser tklauser temporarily deployed to ci July 19, 2022 14:45 Inactive
michi-covalent
michi-covalent approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's roll

@michi-covalent
Copy link
Contributor

just taking a note here, it's probably better to update the release process so that stable.txt gets updated after the release is available. currently there is a small time window where the stable.txt points to a non-existing version.

@tklauser
Copy link
Member Author

just taking a note here, it's probably better to update the release process so that stable.txt gets updated after the release is available. currently there is a small time window where the stable.txt points to a non-existing version.

Good point. Let's change RELEASE.md accordingly after this release.

@tklauser tklauser merged commit b3a95d5 into master Jul 19, 2022
@tklauser tklauser deleted the pr/prepare-v0.12.0 branch July 19, 2022 14:48
tklauser added a commit that referenced this pull request Jul 26, 2022
@tklauser
RELEASE.md: bump version in stable.txt after release
4774337 
Update stable.txt only after the new version was tagged and released.
Otherwise, there is a small time window where stable.txt would point to
an inexistent version.

Ref. #983 (comment)

Suggested-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
@tklauser tklauser mentioned this pull request Jul 26, 2022
Merged
@tklauser
Copy link
Member Author

just taking a note here, it's probably better to update the release process so that stable.txt gets updated after the release is available. currently there is a small time window where the stable.txt points to a non-existing version.

Done in #992

michi-covalent pushed a commit that referenced this pull request Jul 26, 2022
@tklauser @michi-covalent
RELEASE.md: bump version in stable.txt after release
e58f87c 
Update stable.txt only after the new version was tagged and released.
Otherwise, there is a small time window where stable.txt would point to
an inexistent version.

Ref. #983 (comment)

Suggested-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
aditighag pushed a commit to aditighag/cilium-cli that referenced this pull request Apr 21, 2023
@tklauser @aditighag
RELEASE.md: bump version in stable.txt after release
ddc59f1 
Update stable.txt only after the new version was tagged and released.
Otherwise, there is a small time window where stable.txt would point to
an inexistent version.

Ref. cilium#983 (comment)

Suggested-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
michi-covalent pushed a commit to michi-covalent/cilium that referenced this pull request May 30, 2023
@tklauser @michi-covalent
RELEASE.md: bump version in stable.txt after release
8e29a4f 
Update stable.txt only after the new version was tagged and released.
Otherwise, there is a small time window where stable.txt would point to
an inexistent version.

Ref. cilium/cilium-cli#983 (comment)

Suggested-by: Michi Mutsuzaki <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tklauser @michi-covalent