-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON status (fix #956) #958
Conversation
@aditighag is it fine like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the revisions. Can you please squash the commits where you renamed compact -> summary, and the commit with omitempty
additions?
I didn't take a look at the clustermesh changes closely as Tam is already in the reviewer's list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have couple of small comments as per below, but the changes are LGTM in general 💯
I think I've addressed everything (I've given up on the enum because it clashed with the option declaration). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only minor nits inline regarding where OutputJSON
and OutputSummary
are defined. Once these are addressed and all commits squashed into one, this is ready to merge. Thanks a lot!
658b06d
to
8ccc3fb
Compare
@raphink I've squashed all the commits, rebased on top of latest |
Signed-off-by: Raphaël Pinson <[email protected]>
8ccc3fb
to
ff97a32
Compare
Fixes: #956