Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble port-forward: Don't generate Helm manifests #928

Merged
merged 1 commit into from
Jun 16, 2022
Merged

hubble port-forward: Don't generate Helm manifests #928

merged 1 commit into from
Jun 16, 2022

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jun 16, 2022 •
edited by tklauser
Loading

Get hubble-relay service port from Kubernetes APIs instead of relying
on Helm charts. This way the port-forward command works regardless of
how Cilium was installed.

Fixes #904

Signed-off-by: Michi Mutsuzaki [email protected]

@michi-covalent michi-covalent temporarily deployed to ci June 16, 2022 00:38 Inactive
@michi-covalent
Copy link
Contributor Author

michi-covalent commented Jun 16, 2022 •
edited
Loading

✅ manually tested on minikube:

% ./cilium install --chart-directory ../cilium/install/kubernetes/cilium
...

% ./cilium hubble port-forward

Error: Unable to port forward: services "hubble-relay" not found

% ./cilium hubble enable --chart-directory ../cilium/install/kubernetes/cilium
...

% ./cilium hubble port-forward

% hubble status
Healthcheck (via localhost:4245): Ok
Current/Max Flows: 357/4,095 (8.72%)
Flows/s: 5.29
Connected Nodes: 1/1

@michi-covalent
hubble port-forward: Don't generate Helm manifests
d59e15e 
Get hubble-relay service port from Kubernetes APIs instead of relying
on Helm charts. This way the port-forward command works regardless of
how Cilium was installed.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent force-pushed the pr/michi/port-forward branch from 12d2924 to d59e15e Compare June 16, 2022 02:29
@michi-covalent michi-covalent temporarily deployed to ci June 16, 2022 02:29 Inactive
@michi-covalent michi-covalent marked this pull request as ready for review June 16, 2022 02:30
@michi-covalent michi-covalent requested review from a team and joamaki June 16, 2022 02:30
tklauser
tklauser approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tklauser tklauser merged commit 1e1bf42 into master Jun 16, 2022
@tklauser tklauser deleted the pr/michi/port-forward branch June 16, 2022 08:51
@gandro gandro mentioned this pull request Jun 16, 2022
Closed
@tklauser tklauser removed the request for review from joamaki June 16, 2022 12:06
@olga-mir olga-mir mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@gandro gandro gandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium hubble port-forward broken if Cilium was installed via Helm
3 participants
@michi-covalent @gandro @tklauser