sysdump: Log cilium-cli version and arguments #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updating unit tests |
It would be handy to have the cilium-cli version and flags used to
capture the sysdump in cilium-sysdump.log.
Sample outputs:
- No flags:
% ./cilium sysdump
🔍 Collecting sysdump with cilium-cli version: v0.11.5-18-gd3a523a1, args: [sysdump]
- With some flags:
% ./cilium sysdump --hubble-flows-count 10 --hubble-flows-timeout 5s
🔍 Collecting sysdump with cilium-cli version: v0.11.5-18-gd3a523a1, args: [sysdump --hubble-flows-count 10 --hubble-flows-timeout 5s]
Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/sysdump-cli-version
branch
from
f733d9d to
7d86d63
Compare
tklauser
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be handy to have the cilium-cli version and flags used to
capture the sysdump in cilium-sysdump.log.
Sample outputs:
No flags:
With some flags:
Signed-off-by: Michi Mutsuzaki [email protected]