bug: Correct Peer Service Filename; Create Before Relay #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Peer Service file will exist under the hubble subdirectory in the Cilium Helm chart. Additionally, we should create the Peer Service before Hubble-Relay is created, as Relay relies on the Peer Service for communication. Signed-off-by: Nate Sweet <[email protected]>
michi-covalent
approved these changes
Apr 26, 2022
aanm
approved these changes
Apr 26, 2022
michi-covalent
deleted the
pr/nathanjsweet/fix-peer-service-file-references
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Peer Service file will exist under the hubble subdirectory
in the Cilium Helm chart. Additionally, we should create the Peer
Service before Hubble-Relay is created, as Relay relies on the Peer
Service for communication.
Signed-off-by: Nate Sweet [email protected]