Fix release build & update Go to 1.18.1 #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.18 sets the -buildvcs flag to true by default which will stamp VCS information into the binary, see https://go.dev/doc/go1.18#go-version for details. However, in the current `make release` target the release build is performed in a container and the `git status --porcelain` command executed by `go build` under the hood fails with: fatal: unsafe repository ('/cilium-cli' is owned by someone else) To add an exception for this directory, call: git config --global --add safe.directory /cilium-cli Fix this by calling the suggested command in the container to allow the Go toolchain executing git commands there. Signed-off-by: Tobias Klauser <[email protected]>
Signed-off-by: Tobias Klauser <[email protected]>
michi-covalent
approved these changes
Apr 13, 2022
sayboras
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.