store helm values into a Kubernetes secret #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
force-pushed
the
pr/store-information-in-cilium-secret
branch
from
4d2c502 to
18fc2ff
Compare
aanm
force-pushed
the
pr/store-information-in-cilium-secret
branch
from
18fc2ff to
93c64e5
Compare
Similarly to helm behavior, Cilium-cli will store its generated yaml values file in a secret. Signed-off-by: André Martins <[email protected]>
aanm
force-pushed
the
pr/store-information-in-cilium-secret
branch
from
93c64e5 to
4239e9d
Compare
michi-covalent
approved these changes
Apr 11, 2022
@michi-covalent it depends on what we decide to use in the future. Right now, cilium-cli has the control over which manifests we want to install. Also perhaps in the future we will have the ability to control how we perform the upgrade of each manifests and which configmap options should be enabled or not. We kind of lose control of that by doing helm install |
twpayne
approved these changes
Apr 12, 2022
tklauser
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to helm behavior, Cilium-cli will store its generated yaml
values file in a secret.
Signed-off-by: André Martins [email protected]