Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm-based installation for older Cilium versions #771

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

aanm
Copy link
Member

@aanm aanm commented Mar 29, 2022

See per commit basis

Fixes #770

aanm added 2 commits March 29, 2022 19:50
Due some files being changed from their location in recent Cilium helm
versions, the installation was failing for Cilium versions older than
1.11. This commit adds the appropriate logic with the right paths for
older Cilium versions.

Signed-off-by: André Martins <[email protected]>
@aanm aanm requested review from a team as code owners March 29, 2022 17:53
@aanm aanm requested a review from tklauser March 29, 2022 17:53
@aanm aanm temporarily deployed to ci March 29, 2022 17:53 Inactive
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2022
@tklauser tklauser merged commit 3951896 into master Mar 30, 2022
@tklauser tklauser deleted the pr/fix-old-cilium-cli branch March 30, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install any Cilium version specified by --version
4 participants