Update Go to 1.18 #759
Merged
Update Go to 1.18 #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
force-pushed
the
pr/tklauser/update-go-1.18
branch
from
b0e92a2 to
113b4eb
Compare
tklauser
added
the
dont-merge/waiting-for-upstream
Also drop the GH action skip-go-installation option which was removed in v3 of the golangci-lint action (see https://github.com/golangci/golangci-lint-action#compatibility) and switch to skip-cache as the new catch-all (suggested by Robin). Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/update-go-1.18
branch
from
113b4eb to
05138ce
Compare
tklauser
removed
the
dont-merge/waiting-for-upstream
tklauser
force-pushed
the
pr/tklauser/update-go-1.18
branch
from
05138ce to
65bb536
Compare
tklauser
force-pushed
the
pr/tklauser/update-go-1.18
branch
from
65bb536 to
faff75e
Compare
Switch to run golangci-lint using `make check` in CI for now, using the golangci-lint GH action with Go 1.18 is not yet fully supported, see golangci/golangci-lint#2649 This approach was suggested by Robin. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/update-go-1.18
branch
from
faff75e to
673e834
Compare
rolinh
approved these changes
Mar 17, 2022
joestringer
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bump golangci-lint to v1.44.2