Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CRR standalone workload #750

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

jtaleric
Copy link
Member

@jtaleric jtaleric commented Mar 8, 2022

CRR can quickly burn through nf_conntrack_max if the user passes too
many --perf-samples or an extended --perf-duration.

Adding --perf-crr to allow the user to run the CRR test, but it will
be a single sample of 30s.

closes #749

Signed-off-by: Joe Talerico [email protected]

@jtaleric jtaleric requested a review from a team as a code owner March 8, 2022 19:15
@jtaleric jtaleric requested a review from ldelossa March 8, 2022 19:15
@jtaleric jtaleric temporarily deployed to ci March 8, 2022 19:16 Inactive
@jtaleric jtaleric temporarily deployed to ci March 10, 2022 17:51 Inactive
@jtaleric jtaleric temporarily deployed to ci March 14, 2022 11:52 Inactive
@jtaleric jtaleric temporarily deployed to ci March 14, 2022 14:19 Inactive
connectivity/tests/perfpod.go Show resolved Hide resolved
internal/cli/cmd/connectivity.go Outdated Show resolved Hide resolved
connectivity/check/check.go Show resolved Hide resolved
@jtaleric jtaleric temporarily deployed to ci March 14, 2022 20:10 Inactive
@jtaleric jtaleric requested a review from twpayne March 14, 2022 20:13
CRR can quickly burn through `nf_conntrack_max` if the user passes too
many `--perf-samples` or an extended `--perf-duration`.

Adding `--perf-crr` to allow the user to run the CRR test, but it will
be a single sample of 30s.

Signed-off-by: Joe Talerico <[email protected]>
@jtaleric jtaleric temporarily deployed to ci March 15, 2022 13:41 Inactive
@jtaleric
Copy link
Member Author

Failure for multi-cluster is unrelated to the change...

Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tklauser tklauser merged commit 38d7d5a into cilium:master Mar 16, 2022
@jtaleric jtaleric deleted the standalone-crr branch March 16, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Performance] Break CRR into its own test
4 participants