Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: clarify key=value syntax for cilium install --config #748

Merged
merged 1 commit into from
Mar 8, 2022
Merged

internal: clarify key=value syntax for cilium install --config #748

merged 1 commit into from
Mar 8, 2022

Conversation

vosdev
Copy link
Contributor

@vosdev vosdev commented Mar 8, 2022

internal: clarify key=value syntax for cilium install --config

Signed-off-by: Daniel Vos [email protected]

fixes #747

@vosdev vosdev requested a review from a team as a code owner March 8, 2022 11:37
@vosdev vosdev requested a review from twpayne March 8, 2022 11:37
@vosdev vosdev temporarily deployed to ci March 8, 2022 11:37 Inactive
twpayne
twpayne approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 8, 2022
@gandro gandro merged commit 67c140a into cilium:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cilium install --config only takes one key=value
3 participants
@vosdev @twpayne @gandro