connectivity: include k8s-app=coredns matchLabels #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 8d7ddd4 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
|
@samcday can you please add a |
A few policy tests explicitly allow egress to CoreDNS, using an ancient label selector that can't necessarily be relied on. Interestingly, some of the tests (such as client-egress-to-fqdns-one-one-one-one), already had network policies that included a label selector for k8s-app=coredns in addition to k8s-app=kube-dns, but not all. Signed-off-by: Sam Day <[email protected]>
samcday
force-pushed
the
k8s-app-can-be-coredns-too
branch
from
8d7ddd4 to
4cc839f
Compare
|
Oops, sorry, pushed with a proper sign-off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few policy tests explicitly allow egress to CoreDNS, using an ancient
label selector that can't necessarily be relied on. Interestingly, some
of the tests (such as client-egress-to-fqdns-one-one-one-one), already had
network policies that included a label selector for k8s-app=coredns
in addition to k8s-app=kube-dns, but not all.
resolves #697