version: Detect special running Cilium versions #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cilium is installed with 'cilium install --version="-ci:1234"' this version string is added to the standard image names. For the Cilium agent this becomes "quay.io/cilium/cilium-ci:1234". Detect this when decoding version from a running Cilium pod by finding the part after the dash in the image reference, so that the detected version becomes "-ci:1234". This allows hubble to be enabled without passing --hubble-version parameter explicitly in this case. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
added
the
kind/enhancement
michi-covalent
approved these changes
Dec 9, 2021
tklauser
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cilium is installed with 'cilium install --version="-ci:1234"'
this version string is added to the standard image names. For the
Cilium agent this becomes "quay.io/cilium/cilium-ci:1234". Detect this
when decoding version from a running Cilium pod by finding the part
after the dash in the image reference, so that the detected version
becomes "-ci:1234". This allows hubble to be enabled without passing
--hubble-version parameter explicitly in this case.
Signed-off-by: Jarno Rajahalme [email protected]