Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubble: Make UI version configurable #645

Merged
merged 1 commit into from
Dec 7, 2021
Merged

hubble: Make UI version configurable #645

merged 1 commit into from
Dec 7, 2021

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Dec 6, 2021

Fixes #628.

Signed-off-by: Tom Payne [email protected]

@twpayne twpayne requested a review from a team as a code owner December 6, 2021 16:47
@twpayne twpayne requested review from a team and michi-covalent December 6, 2021 16:47
@twpayne twpayne temporarily deployed to ci December 6, 2021 16:47 Inactive
@twpayne
Copy link
Contributor Author

twpayne commented Dec 6, 2021

CI failure looks like a recurrence of #367.

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

hubble/ui.go Show resolved Hide resolved
@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 7, 2021
@tklauser tklauser merged commit 82d268b into cilium:master Dec 7, 2021
@twpayne twpayne deleted the pr/twpayne/make-ui-version-configurable branch December 7, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cilium CLI installs hardcoded, old version of Hubble UI
3 participants