install: Disable BPF masquerading by default #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit bf2c1f9 ("install: Disable kube-proxy-replacement by default") we switched kube-proxy-replacement to disabled by default. We didn't change the default setting for BPF masquerading, even though it requires kube-proxy-replacement to be enabled. As a result, default installation result in a warning when BPF masquerading is forcefully disabled. This commit disables BPF masquerading by default to fix it. We could enable BPF masquerading when kube-proxy-replacement is enabled by the user, but it seems more confusing than anything. Fixes: bf2c1f9 ("install: Disable kube-proxy-replacement by default") Signed-off-by: Paul Chaignon <[email protected]>
pchaigno
force-pushed
the
pr/pchaigno/disable-bpf-masquerading-by-default
branch
from
53cec5f to
451d396
Compare
tklauser
approved these changes
Nov 11, 2021
|
Multicluster hit known flake #600. Other tests are passing and Tobias reviewed. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit bf2c1f9, we switched
kube-proxy-replacementto disabled by default. We didn't change the default setting for BPF masquerading, even though it requireskube-proxy-replacementto be enabled. As a result, default installation result in a warning when BPF masquerading is forcefully disabled.This pull request disables BPF masquerading by default to fix it. We could enable BPF masquerading when
kube-proxy-replacementis enabled by the user, but it seems more confusing than anything.Fixes: #136.