install: Add --rollback option #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbusseneau
approved these changes
Oct 4, 2021
jrajahalme
force-pushed
the
pr/jrajahalme/install-skip-rollback
branch
from
cf77e3d to
5418c15
Compare
jrajahalme
changed the title
nbusseneau
approved these changes
Oct 4, 2021
tklauser
reviewed
Oct 4, 2021
Add an option to control rollback on failed install. This allows install failure debugging e.g. via artifacts collected by the CI by passing '--rollback=false' option to 'cilium install'. With rollback the resources created by a failed install are deleted so they can not be inspected after the fact. Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme
force-pushed
the
pr/jrajahalme/install-skip-rollback
branch
from
5418c15 to
6fd7ca9
Compare
tklauser
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to control rollback on failed install. This allows
install failure debugging e.g. via artifacts collected by the CI by
passing '--rollback=false' option to 'cilium install'. With rollback
the resources created by a failed install are deleted so they can not
be inspected after the fact.
Signed-off-by: Jarno Rajahalme [email protected]