Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysdump: collect CiliumEgressNATPolicy and CiliumLocalRedirectPolicy resources #540

Merged
merged 2 commits into from
Sep 22, 2021
Merged

sysdump: collect CiliumEgressNATPolicy and CiliumLocalRedirectPolicy resources #540

merged 2 commits into from
Sep 22, 2021

Conversation

bmcustodio
Copy link
Contributor

@bmcustodio bmcustodio commented Sep 14, 2021 •
edited
Loading

Closes #517.
Closes #535.

@bmcustodio bmcustodio requested a review from a team as a code owner September 14, 2021 14:45
@bmcustodio bmcustodio requested a review from a team September 14, 2021 14:45
@bmcustodio bmcustodio temporarily deployed to ci September 14, 2021 14:45 Inactive
@bmcustodio bmcustodio temporarily deployed to ci September 14, 2021 14:49 Inactive
ldelossa
ldelossa approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Contingent on tests passing.

@tklauser tklauser changed the title sysdump: collect 'CiliumEgressNATPolicy' resources sysdump: collect CiliumEgressNATPolicy and CiliumLocalRedirectPolicy resources Sep 15, 2021
This was referenced Sep 15, 2021
Closed
Closed
@tklauser
Copy link
Member

The GKE test failure is #342 and unrelated to this change.

@tklauser tklauser merged commit 1d30ccd into master Sep 22, 2021
@tklauser tklauser deleted the pr/bruno/sysdump-ciliumegressnatpolicies branch September 22, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

@tklauser tklauser tklauser approved these changes

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect CiliumEgressNATPolicies in sysdump Collect LocalRedirectPolicy objects in sysdump
4 participants
@bmcustodio @tklauser @errordeveloper @ldelossa