test: Always deploy client2 on same node as client
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node placement for client2 is not currently fixed such that a given test (e.g., client-egress-l7/pod-to-pod/curl-3) may be covering different packet paths on distinct runs (e.g., pod->local pod or pod->remote pod). This nondeterminism can be a bit confusing when debugging as a failure on a specific packet path may appear under various names. This commit fixes the placement of client2 to the same node as client, via an affinity rule. Signed-off-by: Paul Chaignon <[email protected]>
tklauser
approved these changes
Sep 13, 2021
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node placement for
client2is not currently fixed such that a given test (e.g.,client-egress-l7/pod-to-pod/curl-3) may be covering different packet paths on distinct runs (e.g.,pod->local podorpod->remote pod). This nondeterminism can be a bit confusing when debugging as a failure on a specific packet path may appear under various names.This pull request fixes the placement of
client2to the same node asclient, via an affinity rule.