sysdump: collect 'clustermesh-apiserver' + improvements #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for collecting logs for 'clustermesh-apiserver' as well as the 'Deployment' resource itself. Signed-off-by: Bruno Miguel Custódio <[email protected]>
It's fairly safe to assume that all Cilium-related resources live in the same namespace as the Cilium daemonset itself. This commit removes support for specifying different namespaces, and hence simplifies the code a bit. Signed-off-by: Bruno Miguel Custódio <[email protected]>
Be consistent about casing, and let the user know when and why something is expected. Signed-off-by: Bruno Miguel Custódio <[email protected]>
tklauser
reviewed
Sep 2, 2021
Reuse constants defined in the 'defaults' package. Signed-off-by: Bruno Miguel Custódio <[email protected]>
bmcustodio
force-pushed
the
pr/bruno/update-sysdump
branch
from
de37ae0 to
eacf95c
Compare
tklauser
approved these changes
Sep 2, 2021
|
Looks like GH actions weren't triggered on the latest push. I'll close and re-open the PR to trigger them. |
Signed-off-by: Bruno Miguel Custódio <[email protected]>
ldelossa
approved these changes
Sep 2, 2021
michi-covalent
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check individual commits for details.