Add a flag to disable the ipcache check #503
Conversation
Add `--skip-ip-cache-check` flag with the default set to true. This is meant to be a temporary flag while we investigate what's causing the flake. Ref: #361 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/ipcache
branch
from
4eb10be to
6ae2ab5
Compare
michi-covalent
changed the title
|
aks cluster creation failed with this error. re-triggering. https://github.com/cilium/cilium-cli/actions/runs/1184098825
|
|
hitting the same issue again. not sure how to proceed 😞 |
| @@ -119,6 +119,7 @@ func newCmdConnectivityTest() *cobra.Command { | |||
| cmd.Flags().BoolVarP(¶ms.Verbose, "verbose", "v", false, "Show informational messages and don't buffer any lines") | |||
| cmd.Flags().BoolVarP(¶ms.Debug, "debug", "d", false, "Show debug messages") | |||
| cmd.Flags().BoolVarP(¶ms.PauseOnFail, "pause-on-fail", "p", false, "Pause execution on test failure") | |||
| cmd.Flags().BoolVar(¶ms.SkipIPCacheCheck, "skip-ip-cache-check", true, "Skip IPCache check") | |||
There was a problem hiding this comment.
Should we mark this flag as hidden so we can easily remove it again? Given that we intend to fix the ipcache flake #361 eventually,
There was a problem hiding this comment.
Hmmm this makes sense, but at the same time I think that if users face the issue and the flag is hidden they won't know they can use it to proceed.
There was a problem hiding this comment.
Given that we default the flag to true (i.e. skip the ipcache check by default), I think users should not face the ipcache issue anymore. They would need to figure out to run with --skip-ip-cache-check=false at which point they already figured out the flag 😉
There was a problem hiding this comment.
Oh right, makes total sense 💯 — I hadn't looked at the default.
There was a problem hiding this comment.
Looks like this hasn't been addressed before merging. I've opened another PR: #508
There was a problem hiding this comment.
thanks @tklauser , i just saw the green merge button and pushed it 😅
This is an infrastructure issue, waiting for AKS support atm: cilium/cilium#17260 |
|
re-triggered to see if aks happy now 👀 |
Follow-up for #503 to address #503 (comment) Also add a comment so we don't forget to re-enable the check again once issue #361 is resolved. Signed-off-by: Tobias Klauser <[email protected]>
Follow-up for #503 to address #503 (comment) Also add a comment so we don't forget to re-enable the check again once issue #361 is resolved. Signed-off-by: Tobias Klauser <[email protected]>
Follow-up for cilium#503 to address cilium#503 (comment) Also add a comment so we don't forget to re-enable the check again once issue cilium#361 is resolved. Signed-off-by: Tobias Klauser <[email protected]>
Follow-up for cilium#503 to address cilium/cilium-cli#503 (comment) Also add a comment so we don't forget to re-enable the check again once issue cilium#361 is resolved. Signed-off-by: Tobias Klauser <[email protected]>
Add
--skip-ip-cache-checkflag with the default set to true. This ismeant to be a temporary flag while we investigate what's causing the flake.
Ref: #361
Signed-off-by: Michi Mutsuzaki [email protected]