Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for displaying the running Cilium version #482

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Add support for displaying the running Cilium version #482

merged 1 commit into from
Aug 19, 2021

Conversation

zhaojizhuang
Copy link
Contributor

@zhaojizhuang zhaojizhuang commented Aug 12, 2021 •
edited by tklauser
Loading

Show the running version of cilium

Fixes #131

@zhaojizhuang zhaojizhuang requested a review from a team as a code owner August 12, 2021 13:06
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 12, 2021 13:06 Inactive
@zhaojizhuang
Copy link
Contributor Author

zhaojizhuang commented Aug 12, 2021 •
edited
Loading

Just as show below

[root@ ~/code/src/cilium-cli]# cilium version
cilium-cli: v0.8.6-13-g9510a84 compiled with go1.16.6 on linux/amd64
cilium image (default): v1.10.3
cilium image (stable): v1.10.3
cilium image (running): v1.10.3

@zhaojizhuang
Copy link
Contributor Author

/assign @gandro @tklauser

@zhaojizhuang zhaojizhuang temporarily deployed to ci August 12, 2021 13:10 Inactive
gandro
gandro reviewed Aug 12, 2021
View reviewed changes
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 13, 2021 02:41 Inactive
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 17, 2021 02:30 Inactive
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 17, 2021 03:15 Inactive
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 17, 2021 03:52 Inactive
@zhaojizhuang
Copy link
Contributor Author

/assign @errordeveloper

@kaworu kaworu self-requested a review August 17, 2021 14:42
@kaworu kaworu linked an issue Aug 17, 2021 that may be closed by this pull request
Show version of cilium (as well as of cilium-cli) #131
Closed
@kaworu
Copy link
Member

kaworu commented Aug 17, 2021

@zhaojizhuang thanks patch LGTM besides @tklauser comment about the cilium namespace. I think this PR closes #131 as well 🎉

@zhaojizhuang zhaojizhuang temporarily deployed to ci August 18, 2021 02:23 Inactive
tklauser
tklauser reviewed Aug 18, 2021
View reviewed changes
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 18, 2021 08:08 Inactive
@zhaojizhuang zhaojizhuang reopened this Aug 18, 2021
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 18, 2021 08:34 Inactive
@zhaojizhuang zhaojizhuang reopened this Aug 18, 2021
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 18, 2021 11:39 Inactive
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 19, 2021 02:24 Inactive
@tklauser tklauser changed the title add support display running version Add support for displaying the running Cilium version Aug 19, 2021
tklauser
tklauser requested changes Aug 19, 2021
View reviewed changes
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
internal/cli/cmd/version.go Outdated Show resolved Hide resolved
@zhaojizhuang zhaojizhuang temporarily deployed to ci August 19, 2021 07:23 Inactive
@tklauser tklauser requested a review from gandro August 19, 2021 08:31
gandro
gandro approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser tklauser merged commit b663340 into cilium:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@gandro gandro gandro approved these changes

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

@kaworu kaworu Awaiting requested review from kaworu

Assignees

@kaworu kaworu

@errordeveloper errordeveloper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show version of cilium (as well as of cilium-cli)
5 participants
@zhaojizhuang @kaworu @gandro @tklauser @errordeveloper