Document and extend release process #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow Cilium and Hubble and add a stable.txt file in the master branch that always points to the latest stable release of the Cilium CLI. This file can be used e.g. in Cilium CI to always get the latest stable release version. Suggested-by: Robin Hahling <[email protected]> Signed-off-by: Tobias Klauser <[email protected]>
With the updated release procedure, we'll add release notes manually (see next commit). Thus, let the GitHub action create a draft release which will then be published by a maintainer after adding the changelog. Signed-off-by: Tobias Klauser <[email protected]>
rolinh
requested changes
Jul 15, 2021
tklauser
force-pushed
the
pr/tklauser/release-doc
branch
from
14a6228 to
0842eb7
Compare
rolinh
approved these changes
Jul 15, 2021
Document the release process for Cilium CLI. Instructions are based on `RELEASE.md` in the Hubble repo. Note that in addition to the the releases so far, we also update `stable.txt` and publish the changelog in the release notes. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/tklauser/release-doc
branch
from
0842eb7 to
e404944
Compare
nbusseneau
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
LGTM.
Thoughts: I'm thinking we could automate almost everything in there. Full process could be:
- A workflow that needs to be manually triggered, passing in version parameters. When triggered:
- Prepare release notes.
- Update
stable.txtandVERSION. - Push branch and create PR.
- Then, another workflow running on push to
master:- Identify that a release PR just got merged (file names filtering? commit names? PR name?)
- Tag using version from PR
- Create GH release using release notes from PR
|
Thanks @nbusseneau! I've created #435 based on your comment #434 (review) so we don't forget to address it. |
michi-covalent
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the current release process and slightly extend it in two ways:
stable.txtfile which always points to the latest stable version of Cilium CLI.See individual commits for details.
Fixes #363