workflows: Add --timestamps to kubectl logs
#366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
ready-to-merge
tklauser
approved these changes
Jun 24, 2021
|
The external workloads failure is a known flake: #329. |
nebril
approved these changes
Jun 24, 2021
|
EKS seems to have hit a new flake: #367 |
|
Kind also seems to have hit a variant of flake #367. https://github.com/cilium/cilium-cli/pull/366/checks?check_run_id=2905226507 In both cases, we see UDP response packets for the DNS request, but no outgoing TCP connection. Because we don't collect L7 logs, it's not clear what the DNS request was. |
Timestamps are very useful when investigating a unknown CI failure. An example where timestamps would yield us more information is for example when a job runs into a timeout, such as e.g. https://github.com/cilium/cilium-cli/runs/2904654177 where we suspect that it might have run a bit longer than usual, but it's hard to tell. Signed-off-by: Sebastian Wicki <[email protected]>
tklauser
force-pushed
the
pr/gandro/add-timestamps-to-collected-logs
branch
from
18d5cff to
fe21ed5
Compare
|
Rebased to pick up c171080 hopefully helping to avoid some flakes. |
|
The Kind failure looks like another instance of #367. Given that this is the only failure now, I'm merging this as is - it will help us to debug other flakes. |
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps are very useful when investigating a unknown CI failure. An
example where timestamps would yield us more information is for example
when a job runs into a timeout, such as e.g.
https://github.com/cilium/cilium-cli/runs/2904654177 where we suspect
that it might have run a bit longer than usual, but it's hard to tell.
Signed-off-by: Sebastian Wicki [email protected]