Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix CLIVersion ldflag ref #2773

Merged
merged 1 commit into from
Aug 21, 2024
Merged

build: fix CLIVersion ldflag ref #2773

merged 1 commit into from
Aug 21, 2024

Conversation

chenrui333
Copy link
Contributor

seeing some build failure on the homebrew side, Homebrew/homebrew-core#181762, and realized the package re-org per #2762

@chenrui333 chenrui333 requested a review from a team as a code owner August 20, 2024 16:10
@chenrui333 chenrui333 requested a review from asauber August 20, 2024 16:10
asauber
asauber reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the build failure on the Homebrew side catch that debugging symbols had not been stripped?

@chenrui333
Copy link
Contributor Author

Did the build failure on the Homebrew side catch that debugging symbols had not been stripped?

we stripped the debugging symbols for the release build

asauber
asauber approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed locally that this change is needed:

cilium-cli $ build/cilium version
cilium-cli: v0.16.16-3-g083a070e compiled with go1.23.0 on darwin/arm64

Without this change:

cilium-cli $ build/cilium version
cilium-cli:  compiled with go1.23.0 on darwin/arm64

@michi-covalent michi-covalent merged commit 1595a01 into cilium:main Aug 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asauber asauber asauber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @asauber @michi-covalent