{externalworkloads,multicluster}: Shorten cluster names #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shorten cluster names to avoid getting this error:
Error: Unable to install Cilium: execution error at (cilium/templates/validate.yaml:100:5):
The cluster name is invalid: must not be more than 32 characters.
Configure 'upgradeCompatibility' to 1.15 or earlier to temporarily
skip this check at your own risk
Ref: cilium/cilium#33939
Signed-off-by: Michi Mutsuzaki <[email protected]>
Following the upgrade notes [^1]: > With the default enablement of KVStoreMesh, if you use external > workloads, ensure that your cluster has a Cluster name and ID > specified before upgrading. Alternatively, you can explicitly opt out > of KVStoreMesh. [^1]: https://docs.cilium.io/en/stable/operations/upgrade/#upgrade-notes Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/long-name
branch
from
a75f6a9 to
b28552c
Compare
michi-covalent
force-pushed
the
pr/michi/long-name
branch
from
b28552c to
4199f02
Compare
viktor-kurchenko
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorten cluster names to avoid getting this error:
Ref: cilium/cilium#33939
edit: added another commit to set cluster.id in externalworkloads.