Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: use TestNamespace and ExternalDeploymentPort params #2731

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented Jul 30, 2024

in client-egress-l7-http-external-node CNP instead of the fixed values to accommodate the test namespace and external deployment port change.

in client-egress-l7-http-external-node CNP instead of the
fixed values to acconmodate the test namespace and external
deployment port change.

Signed-off-by: Yusuke Suzuki <[email protected]>
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

@ysksuzuki ysksuzuki marked this pull request as ready for review July 30, 2024 03:08
@ysksuzuki ysksuzuki requested review from a team as code owners July 30, 2024 03:08
@ysksuzuki
Copy link
Member Author

Run conformance-e2e on cilium/cilium
https://github.com/cilium/cilium/actions/runs/10154572687/job/28081714508

@jibi jibi merged commit 09486ff into cilium:main Jul 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants