Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags: Use option.NewNamedMapOptions #2684

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

michi-covalent
Copy link
Contributor

Use option.NewNamedMapOptions instead of flags.StringToStringVar to avoid getting lint errors when merging cilium-cli repo to cilium repo 1.

Footnotes

  1. https://github.com/cilium/cilium/blob/main/contrib/scripts/check-viper.sh

Use option.NewNamedMapOptions instead of flags.StringToStringVar to
avoid getting lint errors when merging cilium-cli repo to cilium repo
[^1].

[^1]: https://github.com/cilium/cilium/blob/main/contrib/scripts/check-viper.sh

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent force-pushed the pr/michi/map-struggle branch from d104d28 to b01003e Compare July 15, 2024 00:03
@michi-covalent michi-covalent marked this pull request as ready for review July 15, 2024 00:55
@michi-covalent michi-covalent requested a review from a team as a code owner July 15, 2024 00:55
@michi-covalent michi-covalent requested a review from derailed July 15, 2024 00:55
Copy link
Contributor

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michi-covalent Thank you for this update!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 15, 2024
@michi-covalent michi-covalent merged commit 83d52f1 into main Jul 15, 2024
13 checks passed
@michi-covalent michi-covalent deleted the pr/michi/map-struggle branch July 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants