connectivity: disrupt deployment improved

[viktor-kurchenko]

Deploy conn-disrupt test actors only in the first test namespace in case of tests concurrent run to avoid resource wasting. Conn-disrupt tests always run at the beginning, sequentially and in the first test namespace.

Fixed: #2678

[michi-covalent]

let's add a test for this in one of the workflows. https://github.com/cilium/cilium-cli/blob/main/.github/workflows/kind.yaml is already using --test-concurrency flag, so maybe do this conn disrupt thingy there.

edit: btw kind workflow doesn't seem too happy 👀 https://github.com/cilium/cilium-cli/actions/runs/9911162365/job/27383203458?pr=2679

[viktor-kurchenko]

let's add a test for this in one of the workflows. https://github.com/cilium/cilium-cli/blob/main/.github/workflows/kind.yaml is already using --test-concurrency flag, so maybe do this conn disrupt thingy there.

edit: btw kind workflow doesn't seem too happy 👀 https://github.com/cilium/cilium-cli/actions/runs/9911162365/job/27383203458?pr=2679

I've fixed the error.
Also, kind workflow already contains disrupt tests: here and here.

I think we can do the same for performance tests.

[michi-covalent]

i guess we still need to specify --test-concurrency flag here? 💭

cilium-cli/.github/workflows/kind.yaml

Line 109 in 6d90b8c

--test-concurrency=5 \

[viktor-kurchenko]

i guess we still need to specify --test-concurrency flag here? 💭

cilium-cli/.github/workflows/kind.yaml

Line 109 in 6d90b8c

--test-concurrency=5 \

I've removed --test-concurrency=5 from the first run conn tests run.

Also, please note that --test-namespace test-namespace is renamed to --test-namespace test-namespace-1 otherwise we need to start disrupt tests again for the second run.

[michi-covalent]

for future improvement, maybe it's better to create a namespace cilium-test-1 instead of cilium-test when test-concurrency is set to 1 to get rid of the special case where there is no -$index suffix in the namespace name.

[michi-covalent]

ok i'm merging this. i tried this cilium-cli against the cilium repo, and there are some failures https://github.com/cilium/cilium/actions/runs/9914828717 let's investigate before enabling --test-concurrency flag in cilium repo 🧑‍🔬