Add --disable-check flag to upgrade command #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade command performs the same validation checks as the install command, so add --disable-check flag to the upgrade command as well. Fixes: a5598ec ("Add --disable-check flag back") Signed-off-by: Michi Mutsuzaki <[email protected]>
|
✅ tested manually ✨ |
asauber
approved these changes
Jul 11, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
gotta love that this was already factored out 🚀 |
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Jul 11, 2024
- Run cilium-cli inside a container in preparation to merge cilium-cli repo to cilium repo as proposed in CFP-25694 [^1]. - Move "Install Cilium CLI" step after "Create kind cluster" step so that cilium-cli can access .kube/config file. - Bump cilium-cli version to v0.16.13 to pick up cilium/cilium-cli#2672 - Add --disable-check=minimum-version flag to cilium install. Checking Kind version doesn't make sense when you run cilium-cli from inside a container since it cannot access the kind binary on the host. [^1]: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
to cilium/cilium
that referenced
this pull request
Jul 11, 2024
- Run cilium-cli inside a container in preparation to merge cilium-cli repo to cilium repo as proposed in CFP-25694 [^1]. - Move "Install Cilium CLI" step after "Create kind cluster" step so that cilium-cli can access .kube/config file. - Bump cilium-cli version to v0.16.13 to pick up cilium/cilium-cli#2672 - Add --disable-check=minimum-version flag to cilium install. Checking Kind version doesn't make sense when you run cilium-cli from inside a container since it cannot access the kind binary on the host. [^1]: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
github-merge-queue bot
pushed a commit
to cilium/cilium
that referenced
this pull request
Jul 11, 2024
- Run cilium-cli inside a container in preparation to merge cilium-cli repo to cilium repo as proposed in CFP-25694 [^1]. - Move "Install Cilium CLI" step after "Create kind cluster" step so that cilium-cli can access .kube/config file. - Bump cilium-cli version to v0.16.13 to pick up cilium/cilium-cli#2672 - Add --disable-check=minimum-version flag to cilium install. Checking Kind version doesn't make sense when you run cilium-cli from inside a container since it cannot access the kind binary on the host. [^1]: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade command performs the same validation checks as the install command, so add --disable-check flag to the upgrade command as well.
Fixes: a5598ec ("Add --disable-check flag back")