Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: Label test namespaces #2652

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

michi-covalent
Copy link
Contributor

Sometimes the perf command fails to schedule pods because there are too many pods 1. Add app.kubernetes.io/name label 2 to connectivity test namespaces, and use the label to delete test namespaces before running the perf command.

Footnotes

  1. https://github.com/cilium/cilium-cli/actions/runs/9730132031/job/26852838732

  2. https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

Sometimes the perf command fails to schedule pods because there are too
many pods [^1]. Add app.kubernetes.io/name label [^2] to connectivity
test namespaces, and use the label to delete test namespaces before
running the perf command.

[^1]: https://github.com/cilium/cilium-cli/actions/runs/9730132031/job/26852838732
[^2]: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent marked this pull request as ready for review July 1, 2024 00:29
@michi-covalent michi-covalent requested review from a team as code owners July 1, 2024 00:29
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michi-covalent michi-covalent merged commit b5a0a58 into main Jul 1, 2024
14 of 25 checks passed
@michi-covalent michi-covalent deleted the pr/michi/app-label branch July 1, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants