-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ExternalTargetCANamespace name #2637
Conversation
ed189d8
to
c77db93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nice good catch! 😍
c77db93
to
4a1d50a
Compare
kind failure might be legitimate. i see a similar set of tests failing consistently 💭
|
Oh, no... I'll take a look! Thanks! |
506ff89
to
206d134
Compare
The fix for connectivity tests ExternalTargetCANamespace name. The name must be namespace specific in case of tests concurrent run for proper CiliumNetworkPolicy provisioning. Signed-off-by: viktor-kurchenko <[email protected]>
206d134
to
3fb731e
Compare
@michi-covalent it should work now. |
let me rebase to pick up the multicluster fix |
cilium/cilium-cli#2637 changed the behavior of --test-namespace flag. It's now treated as a prefix, and the namespaces always contain "-$index" suffix even if --test-concurrency is set to 1. Instead of hardcoding the namespace, use app.kubernetes.io/name label to find the test namespace. Signed-off-by: Michi Mutsuzaki <[email protected]>
The fix for connectivity tests ExternalTargetCANamespace name.
The name must be namespace specific in case of tests
concurrent run for proper CiliumNetworkPolicy provisioning.
test-concurrency=5
)test-concurrency=5
)test-concurrency
param)Fix: #2644