external-workloads: Run cilium-cli inside a container #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/external
branch
from
7582d8e to
ae8c6c6
Compare
michi-covalent
force-pushed
the
pr/michi/external
branch
from
ae8c6c6 to
c85ad1e
Compare
michi-covalent
force-pushed
the
pr/michi/external
branch
from
c85ad1e to
18a1b2e
Compare
michi-covalent
force-pushed
the
pr/michi/external
branch
from
18a1b2e to
26998d7
Compare
|
✅ success: https://github.com/cilium/cilium-cli/actions/runs/9671104454/job/26681073692?pr=2630 marking it ready for review |
michi-covalent
force-pushed
the
pr/michi/external
branch
from
26998d7 to
6d472dd
Compare
maintainer-s-little-helper
bot
added
the
ready-to-merge
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/external
branch
from
6d472dd to
1369915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Update docker run command to specify --user flag so that install-external-workload.sh gets created with correct permissions.
Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9