-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multicast subcommand #2620
Add multicast subcommand #2620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes; overall, it looks good. A couple of areas that need work are concurrency and error handling.
This comment was marked as resolved.
This comment was marked as resolved.
Commit d70128e does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will save a detailed review for after the current round of changes.
Thanks @yushoyamaguchi for addressing these comments.
It would be best if you fixed these comments ( these are static syntax checkers and have to make linters happy ).
If you have addressed the comment; feel free to resolve it.
Please add a comment whichever comment is not clear, I will try my best to explain it further. |
General commit comment.
|
@asauber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yushoyamaguchi, for bearing with me on this PR. There are a couple of things I would like to highlight: minor naming changes. And channel creations can be cleaned up. I'd suggest consolidating the channels, as shown in the example in one of the comments.
Thank you for kindly pointing out the places that needed improvement. I've fixed all the points you mentioned. |
Thanks, @yushoyamaguchi, for the change; it looks good. Please squash both commits into a single one. |
@harsimran-pabla |
This commit is to enable multicast status check and configuration from cilium-cli by adding multicast subcommand. The list subcommand show the list of multicast groups or their subscribers on all nodes. The add subcommand joins all nodes to the specified multicast group. The del subcommand deletes the specified multicast group from all nodes. This is follow up of #2574 Signed-off-by: Yusho Yamaguchi <[email protected]>
@harsimran-pabla @asauber @fujitatomoya -san 's approval is required? |
Thanks, @yushoyamaguchi. I think this PR is ready to merge; I believe all concerns are addressed. We can move forward with e2e testing independently. |
I'd suggest reaching out to @fujitatomoya to get his approval as well, since he reviewed this PR. |
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harsimran-pabla @asauber thanks for the reviews, im good to go.
@harsimran-pabla @asauber @michi-covalent @fujitatomoya |
Change
This change adds cilium multicast sub command to manage multicast groups and subscribers throughout the cluster
Following commands are added
This is follow up of #2574
Display example
Additional
As for testing, we will proceed with the implementation of the connectivity test for multicast as described in this issue.(#2615)
Reference
Current way of setup multicast : https://github.com/cilium/cilium/blob/main/Documentation/network/multicast.rst